This repository was archived by the owner on Aug 21, 2024. It is now read-only.
added reporting exact selector matches with a test#95
Open
aunueget wants to merge 4 commits intozmoazeni:masterfrom
Open
added reporting exact selector matches with a test#95aunueget wants to merge 4 commits intozmoazeni:masterfrom
aunueget wants to merge 4 commits intozmoazeni:masterfrom
Conversation
Author
|
I'll be squashing this once we are happy with it if we reach that point. |
Author
|
@zmoazeni |
Owner
|
@aunueget Things have been pretty busy on my side. I'll try and carve out some time in the near future. |
Author
|
Did this ever make it in? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@zmoazeni @icijavon @carsonmcdonald @prsimp @laserlemon @viveksachdeva
resolve #94
resolve #93
This could use some code review.
First time with ruby, thanks to @icijavon.
Tried to match the style you had in the files.
I'm easy about changes so feel free to kill this in Code Review and I'll fix it up.
I could use some help finding out how to identify selectors that are nested(ex. @media) to have a accurate report. Is any variable set to identify what nested area a selector is in?
Test instructions
1)gem install bundle
2)pull branch
3)Install dependencies: bundle install
4) Run tests: bundle exec rake test
5) to test your own css file run: bundle exec csscss my_css_file